Looks good, just need to include the tel_id and selected_gain_channel in the tests and other places where it is used.

One could separate the actual reduction algorithm in the __call__-function to its own function and call it in the Reducers __call__-function to be more coherent with the ImageCleaners. That would make it also possible to call that algorithms by its own.

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 100.00% Coverage (93.70% Estimated after merge)
• 0.00% Duplicated Code (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

One could separate the actual reduction algorithm in the call-function to its own function and call it in the Reducers call-function to be more coherent with the ImageCleaners. That would make it also possible to call that algorithms by its own.

For the image cleaners, the signature between __call__ and the lower-level functions is different. Here it is the same.

Converting to draft.

It seems weird to give cleaning algorithms access to the monitoring data, but not the DVR.

Let's fix that here.